Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inactive selection background color #3803

Closed
Tyriar opened this issue May 13, 2022 · 0 comments · Fixed by #3965
Closed

Support inactive selection background color #3803

Tyriar opened this issue May 13, 2022 · 0 comments · Fixed by #3965
Assignees
@Tyriar
Labels
type/enhancement Features or improvements to existing features
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 13, 2022

Currently we only have selection color, regardless of focus.
@Tyriar Tyriar added the type/enhancement Features or improvements to existing features label May 13, 2022
@Tyriar Tyriar added this to the 5.0.0 milestone Jul 29, 2022
@Tyriar Tyriar self-assigned this Jul 29, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 29, 2022
@Tyriar
Rename ITheme.selection to selectionBackground
2c8be42 
This makes it consistent with selectionForeground and other theme keys and
as a result will make the API easier to work with, especially when inactive
selection is done (xtermjs#3803)
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 29, 2022
@Tyriar
Rename ITheme.selection to selectionBackground
9cb25fb 
This makes it consistent with selectionForeground and other theme keys and
as a result will make the API easier to work with, especially when inactive
selection is done (xtermjs#3803)
@Tyriar Tyriar mentioned this issue Jul 29, 2022
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 29, 2022
@Tyriar
Inactive selection bg in dom renderer
6493679 
Part of xtermjs#3803
@Tyriar Tyriar mentioned this issue Jul 29, 2022
Merged
@Tyriar Tyriar mentioned this issue Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Inactive selection background support Tyriar/xterm.js
1 participant
@Tyriar