Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change w work object pattern to regular variables prefixed with $ #4138

Closed
Tyriar opened this issue Sep 24, 2022 · 0 comments · Fixed by #4162
Closed

Change w work object pattern to regular variables prefixed with $ #4138

Tyriar opened this issue Sep 24, 2022 · 0 comments · Fixed by #4162
Assignees
@Tyriar
Labels
type/proposal A proposal that needs some discussion before proceeding
Milestone
5.1.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 24, 2022 •
edited
Loading

This will make it slightly easier to work with (1 character less, simpler type definition), do a direct variable access instead of object access (may not make perf difference?) and makes it very obvious the variable is special.
@Tyriar Tyriar added the type/proposal A proposal that needs some discussion before proceeding label Sep 24, 2022
@Tyriar Tyriar self-assigned this Sep 24, 2022
@Tyriar Tyriar added this to the 5.1.0 milestone Sep 24, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 24, 2022
@Tyriar
Use $ prefix instead of w.
afc62a1 
Part of xtermjs#4138
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 1, 2022
@Tyriar
Move w objects to $ prefix variables
52ed65d 
Fixes xtermjs#4138
@Tyriar Tyriar mentioned this issue Oct 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/proposal A proposal that needs some discussion before proceeding
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Move w objects to $ prefix variables Tyriar/xterm.js
1 participant
@Tyriar