Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support letter spacing and line height in accessibility buffer #4374

Closed
meganrogge opened this issue Jan 18, 2023 · 0 comments · Fixed by #4375
Closed

support letter spacing and line height in accessibility buffer #4374

meganrogge opened this issue Jan 18, 2023 · 0 comments · Fixed by #4375
Assignees
@meganrogge
Labels
area/accessibility type/enhancement Features or improvements to existing features
Milestone
5.2.0

Comments

@meganrogge
Copy link
Member 

          It would be best if we also supported letter spacing and line height

Originally posted by @Tyriar in #4340 (comment)
@meganrogge meganrogge self-assigned this Jan 18, 2023
@meganrogge meganrogge mentioned this issue Jan 18, 2023
Merged
@Tyriar Tyriar added this to the 5.2.0 milestone Jan 19, 2023
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/accessibility labels Jan 19, 2023
meganrogge added a commit to meganrogge/xterm.js that referenced this issue Jan 19, 2023
@meganrogge
fix xtermjs#4374
7dd1524
@meganrogge meganrogge mentioned this issue Jan 19, 2023
Merged
meganrogge added a commit that referenced this issue Jan 19, 2023
@meganrogge
fix #4374 (#4375)
77870b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
area/accessibility type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

update lineHeight and letterSpacing for Accessibility Buffer meganrogge/xterm.js
2 participants
@Tyriar @meganrogge