Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoration.isDisposed doesn't get changed #4410

Closed
Tyriar opened this issue Feb 9, 2023 · 0 comments · Fixed by #4465
Closed

Decoration.isDisposed doesn't get changed #4410

Tyriar opened this issue Feb 9, 2023 · 0 comments · Fixed by #4465
Assignees
@Tyriar
Labels
type/bug Something is misbehaving
Milestone
5.2.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 9, 2023

Looks like it is initialized to false and never set?

xterm.js/src/common/services/DecorationService.ts

Line 107 in d6599bc

public isDisposed: boolean = false;

image
@Tyriar Tyriar added the type/bug Something is misbehaving label Feb 9, 2023
@Tyriar Tyriar added this to the 5.2.0 milestone Mar 31, 2023
@Tyriar Tyriar self-assigned this Mar 31, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 31, 2023
@Tyriar
Ensure Decoration.isDisposed can be true
c546f7c 
Fixes xtermjs#4410
@Tyriar Tyriar mentioned this issue Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Ensure Decoration.isDisposed can be true Tyriar/xterm.js
1 participant
@Tyriar