"Cannot read properties of undefined (reading 'getRasterizedGlyph')" when a target element is not displayed

[schoonc]

After upgrading from 4.18.0 to 5.2.1, if the mount point is not displayed (e.g. some parent has display: none), this causes an error and xterm crashes. In 4.18.0 this problem was not present.

Details

• Browser and browser version: Vivaldi 6.1.3035.50
• OS version: Ubuntu 23.04
• xterm.js version: 5.2.1

Steps to reproduce

Code:

<div style="display: none" id="target"></div>

import { Terminal } from 'xterm'
import { CanvasAddon } from 'xterm-addon-canvas'

const terminal = new Terminal()
terminal.loadAddon(new CanvasAddon())
terminal.open(document.getElementById('target'))

Console output:

[Tyriar]

The code assumes that _charAtlas is initialized:

https://github.com/Tyriar/xterm.js/blob/ac923e55d2f1f99342301d35acb5ae475b07f651/addons/xterm-addon-canvas/src/BaseRenderLayer.ts#L39

But it may not be:

https://github.com/Tyriar/xterm.js/blob/ac923e55d2f1f99342301d35acb5ae475b07f651/addons/xterm-addon-canvas/src/BaseRenderLayer.ts#L121-L124

[JounQin]

Any schedule to fix this issue?

I noticed there are also several _charAtlas?. usage, can we just add if (!this._charAtlas) { return }? (Sorry I'm not familiar with the source codes)

[AndreSilva1993]

Will this be released? This issue is the only thing blocking us to upgrade since it breaks our automated tests.

[Tyriar]

@AndreSilva1993 you can use the latest beta build which is released on every commit, VS Code is periodically updated to the latest beta