Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getRasterizedGlyph null and undefined check #4596

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Add getRasterizedGlyph null and undefined check #4596

merged 2 commits into from
Jul 16, 2023

Conversation

lewis-sanchez
Copy link
Contributor

@lewis-sanchez lewis-sanchez commented Jul 14, 2023 •
edited
Loading

Ensures that the charAtlas object is not undefined or null before getRasterizedGlyph is invoked.

This PR fixes #4560

@lewis-sanchez lewis-sanchez marked this pull request as draft July 14, 2023 20:00
@lewis-sanchez lewis-sanchez marked this pull request as ready for review July 14, 2023 23:59
@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2023

Thanks!

@Tyriar Tyriar added this to the 5.3.0 milestone Jul 16, 2023
@Tyriar Tyriar self-assigned this Jul 16, 2023
@Tyriar Tyriar merged commit 53d1057 into xtermjs:master Jul 16, 2023
@jonas807900643 jonas807900643 mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

"Cannot read properties of undefined (reading 'getRasterizedGlyph')" when a target element is not displayed
2 participants
@lewis-sanchez @Tyriar