Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset should dispose all decorations #4652

Closed
Tyriar opened this issue Aug 9, 2023 · 2 comments · Fixed by #4671
Closed

reset should dispose all decorations #4652

Tyriar opened this issue Aug 9, 2023 · 2 comments · Fixed by #4671
Assignees
@Tyriar
Labels
area/decorations type/bug Something is misbehaving
Milestone
5.3.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 9, 2023

From: #4651 (comment)

I also noted an issue with decorations/selections from the search addon - if I have selections in the viewport and call reset the decoration boxes get not cleared, but stick to the viewport forever. This happens with all renderers (prolly not a rendering but a state holding issue in the decorations?) and cannot be undone by refreshing or clearing the selection:

Image
@Tyriar Tyriar mentioned this issue Aug 9, 2023
Merged
@Tyriar Tyriar added the type/bug Something is misbehaving label Aug 13, 2023
@Tyriar Tyriar added this to the 5.3.0 milestone Aug 13, 2023
@Tyriar Tyriar self-assigned this Aug 13, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Aug 13, 2023

Something is pretty broken with decoration/marker lifecycle, the numbers below are the mark ids:

image

Still investigating...

@Tyriar
Copy link
Member Author

Tyriar commented Aug 13, 2023

Turns out this is related to SortedList.values() not correctly iterating as elements get removed from _array while it's iterating, so 1/2 the elements get skipped.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 13, 2023
@Tyriar
Fix SortedList.values iteration and general dec lifecycle fixes
70f6fa2 
Fixes xtermjs#4652
@Tyriar Tyriar mentioned this issue Aug 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/decorations type/bug Something is misbehaving
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

Fix SortedList.values iteration and general dec lifecycle fixes Tyriar/xterm.js
1 participant
@Tyriar