Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus and blur events emission #131

Merged
merged 2 commits into from
Jun 16, 2016
Merged

Fix focus and blur events emission #131

merged 2 commits into from
Jun 16, 2016

Conversation

parisk
Copy link
Contributor

@parisk parisk commented Jun 14, 2016

No description provided.

@parisk parisk changed the title [WIP] Fix focus and blur events emission Fix focus and blur events emission Jun 16, 2016
@parisk
Copy link
Contributor Author

parisk commented Jun 16, 2016

/cc @Tyriar could you please take a look at this PR and make a brief test? I removed the debounceRefresh method and embedded its functionality straight into refresh. CPU usage should still not be going crazy with huge streams of data.

@parisk parisk merged commit 09d67a6 into master Jun 16, 2016
@Tyriar
Copy link
Member

Tyriar commented Jun 16, 2016

It seems to perform around the same, my main test for this was that selection of the h1 on the demo was still smooth while ls -lR /usr/share ran. It's still pretty slow in vscode, refresh seems to still 100% CPU, this happened before and after this change though.

Before:

image

After:

image

@Tyriar Tyriar deleted the issue/120 branch October 31, 2016 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants