Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for searching accross wrapped lines #1662

Merged
merged 8 commits into from
Sep 10, 2018

Conversation

alexr00
Copy link
Contributor

@alexr00 alexr00 commented Sep 6, 2018

Fixes #1655

src/Buffer.ts Outdated Show resolved Hide resolved
src/addons/search/SearchHelper.ts Outdated Show resolved Hide resolved
@Tyriar Tyriar added this to the 3.8.0 milestone Sep 7, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 8, 2018

@alexr00 now that the regex PR is merged in I think that's most of the conflicts we will hit, let's fix the conflicts, make sure the ^ and $ work as expected on wrapped line and then they should be good to go 😃

@alexr00
Copy link
Contributor Author

alexr00 commented Sep 10, 2018

Rebased to pickup changes and tested that ^ and $ work as expected on wrapped lines.

@Tyriar Tyriar merged commit 11426bb into xtermjs:master Sep 10, 2018
@alexr00 alexr00 deleted the alexr00/searchWrapped branch September 13, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants