Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve types for listener args in .d.ts #1752

Merged
merged 2 commits into from
Oct 26, 2018
Merged

Improve types for listener args in .d.ts #1752

merged 2 commits into from
Oct 26, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 12, 2018

Without this consumers need an undefined check with strictNullChecks turned on.

@Tyriar
Improve types for listener args in .d.ts
a0250c5 
Without this consumers need an undefined check with strictNullChecks
turned on.
@Tyriar Tyriar added this to the 3.9.0 milestone Oct 12, 2018
@Tyriar Tyriar self-assigned this Oct 12, 2018
@Tyriar Tyriar requested a review from a team October 24, 2018 23:30
mofux
mofux approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@mofux mofux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Tyriar Tyriar merged commit e90f861 into xtermjs:master Oct 26, 2018
@Tyriar Tyriar deleted the improve_dec branch October 26, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofux mofux mofux approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @mofux