Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WheelEvent.deltaY instead of WheelEvent.wheelDeltaY for wheel event #1782

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Use WheelEvent.deltaY instead of WheelEvent.wheelDeltaY for wheel event #1782

merged 1 commit into from
Nov 8, 2018

Conversation

astefanutti
Copy link
Contributor

Fixes #1781

jerch
jerch approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure about possible problems with other older browsers, Safari 9 already supports this (just tested). According to MDN it is supported by others for a long time, I think we are save to add the change.

@jerch jerch added this to the 3.9.0 milestone Nov 8, 2018
@jerch jerch merged commit 70981c7 into xtermjs:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerch jerch jerch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@astefanutti @jerch