Fix #1660: Search as you type

[nojvek]

• Add incremental option to ISearchOptions
• DRY examples page
• Improve performance of translateBufferLineToStringWithWrap with lineCache

Fixes #1660

[Tyriar]

@nojvek I'm happy to go forward with this without tests unless you had a good idea of how to test it. I had a look and it's a bit tricky as right now none of the tests really involve TerminalCore/SelectionManager as they are testing findInLine not findNext/Previous. Addon tests should be made easier as part of #1128 when we also pull these out of the core repo.

[nojvek]

Hi Daniel, I’m on vacation right now so won’t be able to get the tests out. I’m happy with your best judgement. Regards

…

On Fri, Dec 14, 2018 at 7:53 PM Daniel Imms ***@***.***> wrote: @nojvek <https://github.com/nojvek> I'm happy to go forward with this without tests unless you had a good idea of how to test it. I had a look and it's a bit tricky as right now none of the tests really involve TerminalCore/SelectionManager as they are testing findInLine not findNext/Previous. Addon tests should be made easier as part of #1128 <#1128> when we also pull these out of the core repo. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1826 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-JVFBLMKU5WB8F_yBvPdqW5KglYB1Aks5u47R1gaJpZM4ZMaWg> .