Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS Code debug targets for demo server, client and unit tests #1834

Merged
merged 5 commits into from
Dec 27, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 11, 2018

This also fixes the sourcemaps issue that made src/ not resolve in devtools in the demo client as well as simplifies the start.js/server.js scripts to run within the same node instance. Just select the debug target and hit F5:

image

Thanks to @auchenberg for helping out with the sourcemaps issue.

@Tyriar Tyriar added this to the 3.10.0 milestone Dec 11, 2018
@Tyriar Tyriar self-assigned this Dec 11, 2018
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm for me.

@Tyriar Tyriar merged commit c133c64 into xtermjs:master Dec 27, 2018
@Tyriar Tyriar deleted the debugging branch December 27, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants