Fix text being top aligned in latest Chrome and Firefox #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome and Firefox behavior differs, see: - https://bugzilla.mozilla.org/show_bug.cgi?id=737852 - https://bugs.chromium.org/p/chromium/issues/detail?id=607053 Fixes xtermjs#1858
jerch
reviewed
Jan 1, 2019
|
@jerch I don't think we need to get them to align exactly. They're both using the browser's definition of middle which is fine. To be clear, the before screenshots are before the PR, on those versions, not < the version. |
|
Oops, got it, yeah much better now 👍 |
jerch
approved these changes
Jan 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome and Firefox textBaseline behavior has always differed, see:
Plus Chrome seems to have moved to Firefox's behavior in the latest version, moving to middle should fix the problem for both.
Fixes #1858
After Firefox 64
After Chrome 71
Before Firefox 64
Before Chrome 71