Fix search addons: searchTerm should not be matched if the beginning of matching index < 0 #1865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested using
find previous
function in search add-ons. It turns out that searching cannot go to previous line if the current result start at column index0
as seen in the following picture:The current selection (the first
meow
at second line) is stuck and couldn't continue finding other results. I think it's becauselastIndexOf
function still do matching string at the beginning ofsearchStringLine
althoughsearchStringLine
's length is smaller thansearchTerm
, which should return-1
. I fix the code by adding if clause to check whether the comparing range ofsearchStringLine
is shorter thansearchTerm
or not.