*actually* fix mouse handler before term attached #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
force-pushed
the
sp/mousehandlerfix
branch
from
2139915
to
a3b2591
Compare
|
Argh, I messed this up again (got |
pfitzseb
force-pushed
the
sp/mousehandlerfix
branch
from
a3b2591
to
0854f84
Compare
Tyriar
approved these changes
Mar 4, 2019
|
Thanks for the style fix (I should really try to remember to run a linter locally before pushing) and merge! :) |
|
@pfitzseb np, CI made it easy for me to do 😃. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #1905, which I apparently didn't test properly -- turns out
_terminal.selectionManagerisn't initialized either untilterminal.open()is called...With this additional fix opening a tmux session in an un-
opened terminal works.It would probably be a good idea to test this somewhere, but I'm not sure where to put this kind of integration test.