Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reflow when winptyCompat is on #1950

Merged
merged 3 commits into from
Mar 7, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 20, 2019

Fixes #1943


This is a quick and dirty fix that should completely disable reflow when winptyCompat is on (ie. the terminal backend is Windows-based). This prevents a potential crash.

@Tyriar Tyriar added this to the 3.12.0 milestone Feb 20, 2019
@Tyriar Tyriar self-assigned this Feb 20, 2019
@Tyriar Tyriar requested a review from jerch February 20, 2019 15:04
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I dont like the any type in the helper method, any chance we could refactor this into winCompact realms later on?

@Tyriar
Copy link
Member Author

Tyriar commented Mar 7, 2019

@jerch I want to have this addon built in later as part of #1128, so the hack will go away at that point.

@Tyriar Tyriar merged commit 9597ad2 into xtermjs:master Mar 7, 2019
@Tyriar Tyriar deleted the 1943_winpty_compat_reflow branch March 7, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflow can still happen on Windows which can break the terminal
2 participants