Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move new format addons into repo, remove old addons #2164

Merged
merged 30 commits into from
Jun 2, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 1, 2019

Fixes #2142
Fixes #2161


Notes

  • The addons are built like they were before using tsconfig.all.json, they have been moved out of src however to further disassociate them with the core code
  • The demo uses the addons in a very similar way to how they would when using the module from npm.
  • The addon folders don't get their dependencies installed, instead they rely on the main node_modules and only have a single script for publish which calls ../../../node_modules/.bin/tsc directly
  • The addons are scoped to @xtermjs as this is what it will be when we use the GH package registry
  • I archived the repos xterm-addon-attach, xterm-addon-search and xterm-addon-web-links
  • Removed the addon label and added separate area labels for each addon

@Tyriar Tyriar added this to the 4.0.0 milestone Jun 1, 2019
@Tyriar Tyriar self-assigned this Jun 1, 2019
@mofux
Copy link
Contributor

mofux commented Jun 2, 2019

Works great and LGTM 👍. Does it make sense to add some words about how the addons work and how they share their dependencies with the root project to our wiki?

@Tyriar
Copy link
Member Author

Tyriar commented Jun 2, 2019

@mofux good idea, I was also thinking it might be good to detail the #1507 wip in the wiki as things will probably be in flux for quite a while still.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 2, 2019

Updated the wiki

@Tyriar Tyriar merged commit e1353c1 into xtermjs:master Jun 2, 2019
@Tyriar Tyriar deleted the addons_in_repo branch June 2, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we use a monorepo structure for addons? Remove applyAddon and old addons
2 participants