Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

True color support in WebGL renderer #2552

Merged
merged 25 commits into from
Nov 10, 2019
Merged

True color support in WebGL renderer #2552

merged 25 commits into from
Nov 10, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 10, 2019 •
edited
Loading

Fixes #2248
Fixes #2249
Fixes #2250

@Tyriar Tyriar added this to the 4.3.0 milestone Nov 10, 2019
@Tyriar Tyriar self-assigned this Nov 10, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Nov 10, 2019

On selection color, currently the default is #FFFFFF77 which would draw pure white on WebGL. I guess WebGL needs to resolve the alpha value against the background in order to keep both renderers to look approximately the same when using alpha values.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 10, 2019

Selection works now based on the computed selectionOpaque value

@Tyriar Tyriar merged commit a8ff27c into xtermjs:master Nov 10, 2019
@Tyriar Tyriar deleted the webgl_compat_attr branch November 10, 2019 19:37
This was referenced May 17, 2020
Closed
Open
@XVilka XVilka mentioned this pull request Jul 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Webgl: Support custom selection colors Webgl: Support true color rendering Webgl: Remove CharDataCompat
1 participant
@Tyriar