Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure underscore is within cell bounds #3426

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 19, 2021

Fixes #3423

Decided against using the customGlyphs setting for this and instead just making it baseline behavior.

@Tyriar Tyriar added this to the 4.14.0 milestone Aug 19, 2021
@Tyriar Tyriar requested a review from meganrogge August 19, 2021 14:06
@Tyriar Tyriar self-assigned this Aug 19, 2021
@Tyriar Tyriar enabled auto-merge August 19, 2021 14:12
@Tyriar Tyriar merged commit ac116b9 into xtermjs:master Aug 19, 2021
@Tyriar Tyriar deleted the underscore_fix branch August 19, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draw custom underscore glyph if it's determined it would be drawn outside of the cell
1 participant