Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3425 (Terminal controls shifted to the right of the demo) #3439

Merged
merged 4 commits into from
Aug 31, 2021

Conversation

simran916
Copy link
Contributor

Issue: #3425

All the terminal controls have been shifted to the side of the demo with a toggling tab bar for Options, AddOns, and Style. The screenshots of the modified UI have been attached for reference. Hope this would help to resolve issue #3425
Capture_Options
Capture_Add0ns
Capture_Style

The terminals have been shifted using a fixed tab bar on the right side of the demo.
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice 👍

demo/index.html Outdated Show resolved Hide resolved
demo/index.html Outdated Show resolved Hide resolved
demo/style.css Show resolved Hide resolved
@Tyriar Tyriar added this to the 4.14.0 milestone Aug 30, 2021
@Tyriar Tyriar linked an issue Aug 30, 2021 that may be closed by this pull request
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for the contribution 👍

@Tyriar Tyriar merged commit d260a72 into xtermjs:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move most terminal controls to the side of the demo
2 participants