Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix text baseline for Legacy Edge #3621

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix text baseline for Legacy Edge #3621

merged 1 commit into from
Jan 31, 2022

Conversation

felixse
Copy link
Contributor

@felixse felixse commented Jan 30, 2022

Legacy Edge (or in my case the UWP WebView) has similar as issues as Firefox had with 'ideographic'

Tyriar
Tyriar approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixse 👍

@Tyriar Tyriar added this to the 4.17.0 milestone Jan 31, 2022
@Tyriar Tyriar merged commit 5a3e061 into xtermjs:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felixse @Tyriar