Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout dimension left/right after renderer dims change #3779

Merged
merged 6 commits into from
May 16, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 11, 2022

Fixes #3773

@Tyriar Tyriar added this to the 4.19.0 milestone May 11, 2022
@Tyriar Tyriar requested a review from meganrogge May 11, 2022 17:13
@Tyriar Tyriar self-assigned this May 11, 2022
@Tyriar Tyriar marked this pull request as ready for review May 11, 2022 17:13
Copy link
Member

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't _dimensionsChanged get reset to false somewhere?

@Tyriar
Copy link
Member Author

Tyriar commented May 12, 2022

@meganrogge I knew there was a reason I requested a review 😉

@Tyriar Tyriar requested a review from meganrogge May 12, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Going from webgl renderer to dom renderer will not reposition decorations
2 participants