Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake registerLinkProvider tests #3822

Merged
merged 4 commits into from
May 19, 2022
Merged

Deflake registerLinkProvider tests #3822

merged 4 commits into from
May 19, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 19, 2022

The root cause of this flakiness problem was related to the click event
handler. For some reason it would not go off on some links but it would
when clicking elsewhere in the terminal. I tried a bunch of things to
keep the click handler to no avail, instead opting to move to using
mousedown and mouseup events for activating links which comes with the
nice benefit of ensuring that the link on mouseup is the same one on
mousedown.

Fixes #3821

The root cause of this flakiness problem was related to the click event
handler. For some reason it would not go off on some links but it would
when clicking elsewhere in the terminal. I tried a bunch of things to
keep the click handler to no avail, instead opting to move to using
mousedown and mouseup events for activating links which comes with the
nice benefit of ensuring that the link on mouseup is the same one on
mousedown.

Fixes xtermjs#3821
@Tyriar Tyriar added this to the 4.19.0 milestone May 19, 2022
@Tyriar Tyriar requested a review from meganrogge May 19, 2022 22:32
@Tyriar Tyriar self-assigned this May 19, 2022
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Tyriar and others added 2 commits May 19, 2022 15:51
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registerLinkProvider integration tests are quite flaky
2 participants