Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix devcontainer docker build #3907

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix devcontainer docker build #3907

merged 1 commit into from
Jul 18, 2022

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Jul 18, 2022

Moves the devcontainer from Debian stretch to Debian buster.

  • The node:14 docker container already moved to Debian buster some time ago, but not all required packages are available so it was failing to build the devcontainer completely.
  • Removes the puppeteer dependencies instead of finding replacements.

Reference: nodejs/docker-node@4f1d6a3

Tyriar
Tyriar reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this move to stretch instead? That would get puppeteer working again?

@silamon
Copy link
Contributor Author

silamon commented Jul 18, 2022 •
edited
Loading

Should this move to stretch instead? That would get puppeteer working again?

I don't see any references anymore to puppeteer, it's been replaced by playwright some years ago?
Debian stretch has been in LTS until June 2022. Therefore it was replaced in the node:14 docker image.

Tyriar
Tyriar approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I got mixed up

@Tyriar Tyriar added this to the 4.20.0 milestone Jul 18, 2022
@Tyriar Tyriar merged commit 86cfad5 into xtermjs:master Jul 18, 2022
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
@silamon silamon deleted the devcontainerdeprecation branch October 16, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@silamon @Tyriar