Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Delete in CompositionHelper #4007

Merged
merged 6 commits into from
Sep 7, 2022

Conversation

ink404
Copy link
Contributor

@ink404 ink404 commented Aug 8, 2022

Details

Browser

Tested in chrome on Android device running SDK 12.

Version 4.19.0

Issue - relates to #3600

Deleting characters doesn't work as expected on Android since the CompositionHelper expects the diff to have > 1 length if there's a difference.

Steps:

  • type: 1
  • tap backspace button

expected:

  • character is removed

actual:

  • character remains, tapping backspace once more then removes character

Example:

@ink404
Copy link
Contributor Author

ink404 commented Aug 29, 2022

@Tyriar Hi! This fixes a long standing issue for our use case.

Is there any chance this can be looked at in the next week?

@Tyriar Tyriar added this to the 5.0.0 milestone Sep 7, 2022
@Tyriar Tyriar self-assigned this Sep 7, 2022
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, I didn't test on Android but it doesn't seem to regress desktop and makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants