Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DECRQM support #4095

Merged
merged 5 commits into from
Sep 7, 2022
Merged

DECRQM support #4095

merged 5 commits into from
Sep 7, 2022

Conversation

jerch
Copy link
Member

@jerch jerch commented Sep 1, 2022

Shall fix #4091.

Tyriar
Tyriar reviewed Sep 2, 2022
View reviewed changes
src/common/InputHandler.ts Outdated Show resolved Hide resolved
@jerch jerch mentioned this pull request Sep 2, 2022
Closed
@jerch
Copy link
Member Author

jerch commented Sep 3, 2022

@Tyriar I changed 2 things in DECSET and SM:

  • SM 20 - newline mode: we fully support that from the internals, but it was commented out, dunno why, re-enabled it
  • DECSET 12 - blinking cursor: In the past the renderer were not able to handle that, but now all do, thus I re-enabled it.

Those 2 changes should not break anything, but you might want to revisit them and if they got disabled for other reasons in the first place.

Ready for review.

@jerch jerch marked this pull request as ready for review September 3, 2022 11:32
@Tyriar Tyriar added this to the 5.0.0 milestone Sep 7, 2022
@Tyriar Tyriar assigned Tyriar and jerch and unassigned Tyriar Sep 7, 2022
Tyriar
Tyriar approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@Tyriar Tyriar merged commit e9d276a into xtermjs:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@jerch jerch

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

DECRQM support
2 participants
@jerch @Tyriar