Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition that could when clearing atlas on 2+ terminals #4181

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Fix race condition that could when clearing atlas on 2+ terminals #4181

merged 1 commit into from
Oct 7, 2022

Commits on Oct 7, 2022

  1. Fix race condition that could when clearing atlas on 2+ terminals 

    This is the proper fix for microsoft/vscode#162996, after a bunch of
investigation we found that this is causing the problem:

VS Code clears the texture atlas on OS resume to fix an issue where the texture
could be corrupted. This calls clearTextureAtlas twice which should be fine, but
it's not because inside WebglRenderer.clear we're calling updateModel which is
meant to only ever be called in an animation frame. This calls potentially both
renderers to have stale views of the texture atlas for those rows and our perf
caching of cells (the main purpose of the model) doesn't know it's stale.

Co-Authored-By: Megan Rogge <merogge@microsoft.com>
    @Tyriar @meganrogge
    Tyriar and meganrogge committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    c4eef2f View commit details
    Browse the repository at this point in the history