Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure stale bitmap is not used when drawing new characters #4189

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 8, 2022

This would cause a problem where the first time a glyph is used it would not be visible because it was using the old invalidated bitmap.

This would cause a problem where the first time a glyph is used it would
not be visible because it was using the old invalidated bitmap.
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 8, 2022
@Tyriar Tyriar self-assigned this Oct 8, 2022
@Tyriar Tyriar enabled auto-merge October 8, 2022 18:57
@Tyriar Tyriar merged commit a22ad76 into xtermjs:master Oct 8, 2022
@Tyriar Tyriar deleted the ensure_canvas_changed branch October 10, 2022 14:04
Tyriar added a commit to microsoft/vscode that referenced this pull request Oct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195
- Improve dotted line for canvas xtermjs/xterm.js#4100
- Fix demo again xtermjs/xterm.js#4193
- Switch to Ubuntu 20.04 xtermjs/xterm.js#4192
- Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180
- Create theme service xtermjs/xterm.js#4188
- Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189
- Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187
- Fix a bunch of memory retention problems xtermjs/xterm.js#4185
Tyriar added a commit to microsoft/vscode that referenced this pull request Oct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195
- Fix demo again xtermjs/xterm.js#4193
- Switch to Ubuntu 20.04 xtermjs/xterm.js#4192
- Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180
- Create theme service xtermjs/xterm.js#4188
- Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189
- Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187
- Fix a bunch of memory retention problems xtermjs/xterm.js#4185
lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195
- Fix demo again xtermjs/xterm.js#4193
- Switch to Ubuntu 20.04 xtermjs/xterm.js#4192
- Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180
- Create theme service xtermjs/xterm.js#4188
- Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189
- Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187
- Fix a bunch of memory retention problems xtermjs/xterm.js#4185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant