Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering of dotted underlines #4350

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 23, 2022

Fixes #4060

Moving the different rendering depending on x offset discussion into a new issue:

New

1 dpr:

image
image

1.5 dpr:

image
image

2 dpr:

image
image

@Tyriar Tyriar added this to the 5.2.0 milestone Dec 23, 2022
@Tyriar Tyriar self-assigned this Dec 23, 2022
@Tyriar Tyriar merged commit 72f1d10 into xtermjs:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dotted underline looks more like dashed
1 participant