make the accessibility buffer readonly #4388
Conversation
| if (['ArrowUp', 'ArrowLeft', 'ArrowRight', 'ArrowDown', 'Tab', 'Shift'].includes(event.key)) { | ||
| return; | ||
| } | ||
| event.preventDefault(); | ||
| event.stopImmediatePropagation(); |
There was a problem hiding this comment.
There are other ways to navigate text (page up, home, etc.). Do we need to prevent writing like this? Restricting it in this way seems more harmful than just allowing editing it?
There was a problem hiding this comment.
We have heard from screen reader users in the issue linked and similar that mutating the buffer is unexpected and not desirable.
There was a problem hiding this comment.
By only allowing certain keys, we can make sure that doesn't happen while not messing up the scrolling via the readOnly property
There was a problem hiding this comment.
Something I was thinking about recently was that with the move to a textarea, that makes the move to a semantic buffer not possible as you cannot have elements inside a textarea's value. So I think we should go back to a tabindex div with a contenteditable setting (for non-screen readers, until we get F7 caret browsing mode) anyway
There was a problem hiding this comment.
when it's not content editable, screen readers cannot do anything w a div, but we can do something like this PR does to prevent unwanted edits
There was a problem hiding this comment.
I also don't think non-screen reader users will gain anything from this unless it is content editable, so we should probably just go with that for everyone.
but still accept arrow keys
172714