Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accessibilityBuffer: textarea -> div & prevent mouse click from exiting #4389

Merged
merged 15 commits into from
Feb 1, 2023
Merged

accessibilityBuffer: textarea -> div & prevent mouse click from exiting #4389

merged 15 commits into from
Feb 1, 2023

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge commented Jan 31, 2023 •
edited
Loading

@meganrogge meganrogge removed the request for review from Tyriar January 31, 2023 17:43
@meganrogge meganrogge marked this pull request as draft January 31, 2023 17:43
@meganrogge meganrogge self-assigned this Jan 31, 2023
@meganrogge meganrogge marked this pull request as ready for review January 31, 2023 17:59
Tyriar
Tyriar previously requested changes Jan 31, 2023
View reviewed changes
src/browser/AccessibilityManager.ts Outdated Show resolved Hide resolved
@Tyriar Tyriar added this to the 5.2.0 milestone Jan 31, 2023
@meganrogge meganrogge changed the title prevent mouse click from exiting the accessibility buffer accessibilityBuffer: textarea -> div & prevent mouse click from exiting the accessibility buffer Jan 31, 2023
@meganrogge meganrogge changed the title accessibilityBuffer: textarea -> div & prevent mouse click from exiting the accessibility buffer accessibilityBuffer: textarea -> div & prevent mouse click from exiting Jan 31, 2023
@meganrogge meganrogge enabled auto-merge (squash) January 31, 2023 23:18
@meganrogge meganrogge merged commit a9da61e into xtermjs:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar left review comments

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Clicking on the terminal while in accessibility mode exits accessibility mode
2 participants
@meganrogge @Tyriar