Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use border-bottom instead of box-shadow for underline cursor #4584

Merged
merged 1 commit into from
Aug 1, 2023
Merged

use border-bottom instead of box-shadow for underline cursor #4584

merged 1 commit into from
Aug 1, 2023

Commits on Jul 5, 2023

  1. use border-bottom instead of box-shadow for underline cursor 

    In rare cases, box-shadow can cause aliasing artifacts on the top and
sides of the cursor box when only the bottom should be filled in to
create an underline.

This replaces the box-shadow style with border-bottom which should be
pixel perfect in all cases.

Fixes: xtermjs#4580
    @dlech
    dlech committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    9663429 View commit details
    Browse the repository at this point in the history