Add IntRange type for ColorIndex #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
commented
Jul 28, 2023
src/common/InputHandler.ts
Outdated
Comment on lines
3433
to
3435
| function isValidColorIndex(value: number): value is ColorIndex { | ||
| return 0 <= value && value < 259; | ||
| } |
There was a problem hiding this comment.
@jerch should this be < 256 instead? If so what would be a good name for this color index sub-range? IsValidInputColorIndex or something?
There was a problem hiding this comment.
Yes, for colors the index is only 0..255, so its better to test for that range in during input. The fg/bg/cursor entries on top are an amalgamation, so the events and methods dont need re-declaration and/or branching.
jerch
reviewed
Jul 28, 2023
src/common/Types.d.ts
Outdated
| : Enumerate<N, [...Acc, Acc['length']]>; | ||
| type IntRange<F extends number, T extends number> = Exclude<Enumerate<T>, Enumerate<F>>; | ||
|
|
||
| type ColorIndex = IntRange<0, 259>; // number from 0 to 258 |
There was a problem hiding this comment.
Would it be clearer to limit ColorIndex here to 0..255, and to merge into a super type with the fg/bg/cursor values in a second step? Also the test function above can then refer to that narrower ColorIndex type.
jerch
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4614