fix double underline, upwards #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Aug 8, 2023
Comment on lines
1022
to
1030
| if (imageData.data[offset] === r && | ||
| imageData.data[offset + 1] === g && | ||
| imageData.data[offset + 2] === b) { | ||
| imageData.data[offset + 1] === g && | ||
| imageData.data[offset + 2] === b) { | ||
| imageData.data[offset + 3] = 0; | ||
| } else { | ||
| // Check the threshold based difference | ||
| if (enableThresholdCheck && | ||
| (Math.abs(imageData.data[offset] - r) + | ||
| (Math.abs(imageData.data[offset] - r) + | ||
| Math.abs(imageData.data[offset + 1] - g) + |
There was a problem hiding this comment.
Can you revert these? The intent here is to double-indent wrapped lines to easily differentiate them from the lines inside the block. You might need to disable prettier if you're using that.
There was a problem hiding this comment.
ou.....I restore it. 😶🌫️
Comment on lines
546
to
549
| this._tmpCtx.moveTo(xChLeft, yTop - ySpace); | ||
| this._tmpCtx.lineTo(xChRight, yTop - ySpace); | ||
| this._tmpCtx.moveTo(xChLeft, yTop); | ||
| this._tmpCtx.lineTo(xChRight, yTop); |
There was a problem hiding this comment.
Since we're fixing a limitation of the canvas renderer, we still want the old ideal behavior on the webgl renderer. So this should be based on a flag passed into _drawToCache, something like restrictToCellHeight: boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4476