Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions #4693

Merged
merged 61 commits into from
Aug 19, 2023
Merged

GitHub Actions #4693

merged 61 commits into from
Aug 19, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 19, 2023

Fixes #3297


Typical master build on Azure Pipelines ~15 minutes:

Screenshot 2023-08-19 at 12 57 51 pm

After:

Screenshot 2023-08-19 at 3 25 28 pm

@Tyriar Tyriar self-assigned this Aug 19, 2023
@jerch
Copy link
Member

jerch commented Aug 19, 2023

@Tyriar Wanna move away from azure CI? Tbh I found the gh-action based CI more reliable (from other projects), than azure in xtermjs. I kinda never get timeout errors on gh-actions, while azure seems to cause testing issue from high load sometimes.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 19, 2023

I do, mainly because it's a little more integrated and easier to get to the failures. It's looking quite nice so far, will see how publish goes

@Tyriar Tyriar added this to the 5.3.0 milestone Aug 19, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Tyriar Tyriar marked this pull request as ready for review August 19, 2023 16:45
Comment on lines 47 to 48
- name: Integration tests (Chromium)
run: yarn test-api-chromium --headless --forbid-only
Copy link
Member

@jerch jerch Aug 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would merging the browser tests into one container defintion help to speedup things?

I also wonder, if we should add back safari/webkit testing at some point, though I dont recall, why we removed it in the first place. We kinda have a blind spot there atm.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If agents all get provisioned then as much parallelization as possible would be the fastest. The integration tests for each browser takes several minutes.

I think for webkit there were issues when it was originally set up and never looked into after that.

@Tyriar Tyriar merged commit 6dae811 into master Aug 19, 2023
14 checks passed
@Tyriar Tyriar deleted the Tyriar-patch-1 branch August 19, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to GitHub Actions
2 participants