Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling of invisible #4762

Merged
merged 5 commits into from
Sep 9, 2023
Merged

Add handling of invisible #4762

merged 5 commits into from
Sep 9, 2023

Conversation

tisilent
Copy link
Contributor

@tisilent tisilent commented Sep 8, 2023

fix #4758

@Tyriar Tyriar added this to the 5.4.0 milestone Sep 9, 2023
@Tyriar Tyriar self-assigned this Sep 9, 2023
Tyriar
Tyriar approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a regression test (in a new sub-suite) after figuring out the exact problem case

@Tyriar Tyriar merged commit 2f2154c into xtermjs:master Sep 9, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

Invisible text is visible in the DOM renderer
2 participants
@tisilent @Tyriar