using isCursorInitialized for domrenderer

[tisilent]

fix #4790

[tisilent]

Testing failed in Linux... 😒

[Tyriar]

It would be initialized because for each test Terminal.reset() is called:

xterm.js/test/playwright/SharedRendererTests.ts

Line 18 in 32c6165

await ctx.value.proxy.reset();

This does not reset the cursor initialization state:

xterm.js/src/browser/Terminal.ts

Lines 1231 to 1251 in 32c6165

	public reset(): void {
	/**
	* Since _setup handles a full terminal creation, we have to carry forward
	* a few things that should not reset.
	*/
	this.options.rows = this.rows;
	this.options.cols = this.cols;
	const customKeyEventHandler = this._customKeyEventHandler;
	this._setup();
	super.reset();
	this._selectionService?.reset();
	this._decorationService.reset();
	this.viewport?.reset();
	// reattach
	this._customKeyEventHandler = customKeyEventHandler;
	// do a full screen refresh
	this.refresh(0, this.rows - 1);
	}

Since creating a new terminal can complicate the test side effects, we could solve this by making a new inject function:

export function injectSharedRendererTestsStandalone(ctx: ISharedRendererTestContext): void {
  ...
}

These can then re-create the terminal before each test which is probably just a matter of calling dispose terminal and then openTerminal. Similar to what happens in this test but instead in a new describe/beforeEach:

  test('render when visible after hidden', async () => {
    await openTerminal(ctx);
    await ctx.page.evaluate(`
      if ('term' in window) {
        try {
          window.term.dispose();
        } catch {}
      }
    `);
    await ctx.page.evaluate(`document.querySelector('#terminal-container').style.display='none'`);
    await ctx.page.evaluate(`window.term = new Terminal()`);
    await ctx.page.evaluate(`window.term.open(document.querySelector('#terminal-container'))`);
    await ctx.page.evaluate(`document.querySelector('#terminal-container').style.display=''`);
    await pollFor(ctx.page, `window.term._core._renderService.dimensions.css.cell.width > 0`, true);
  });

[tisilent]

I see, adjust it.

[tisilent]

I still need to modify. This way of opening the page is inefficient.

[Tyriar]

LGTM provided it changes after my changes to also run these in canvas/webgl 👍