Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setCellFromCodePoint API and rename to setCellFromCodepoint #4825

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

PerBothner
Copy link
Contributor

Replace fg, bg, and eAttrs parameters by single IAttributeData parameter. In addition to making for a simpler/cleaner API, it also increases flexibility for future CellData or BufferLine changes.
(Rename function to reduce risk of using accidentally using old function.)

Also removed redundant eraseAttr parameter in deleteCells, insertCells, and replaceCells.

These changes will be helpful for issue #4800.

Replace fg, bg, and eAttrs parameters by single IAttributeData parameter.
In addition to making for a simpler/cleaner API, it also increases flexibility
for future CellData or BufferLine changes.
(Rename function to reduce risk of using accidentally using old function.)

Also removed redundant eraseAttr parameter in deleteCells, insertCells, and replaceCells.
@Tyriar Tyriar added this to the 5.4.0 milestone Oct 2, 2023
@Tyriar Tyriar self-assigned this Oct 2, 2023
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what you get from evolving interfaces over time, was way overspecified/explicit 😸

Thx for cleaning it up - LGTM 👍

@Tyriar Tyriar merged commit 13be985 into xtermjs:master Nov 3, 2023
18 of 19 checks passed
@PerBothner
Copy link
Contributor Author

Thanks! I'm continuing to work on issue #4800 - currently focusing on line-wrapping. (I'm looking into doing lazy reflow as per issue #4232.)

@PerBothner PerBothner deleted the setcell-refactor branch November 3, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants