-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose API method for writing to application side (#4948) #4953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome and thank you for looking into this.
Looks really good already, only a few my remarks from my side below.
Thanks for the feedback, working on it |
…the input was user input or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arencoskun With fixing the remaining linter errors, this LGTM 👍
Oops, forgot to fix those. Will work on it in a few moments |
@arencoskun Oh and btw - the declaration also needs to be added to |
No problem, also adding that |
Sorry, forgot to mark as draft |
Whoopsie - the headless API-bundling class in (Why? - We basically maintain 2 versions of xterm.js Terminal class - one for browser and for headless nodejs usage. So parts of the API bundling is doubled here.) |
Thanks for the info, I've been busy tonight but most probably tomorrow I'll finish it off. |
@Tyriar Could you also review this PR? Because of the API addition I dont want to merge it w'o being reviewed by you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I just tweaked the docs and removed the doc strings from the internal files to reduce duplication/bitrot
This PR adds an input method which takes data as the parameter as described in the issue. If there are any issues, you can point it out and I'll fix it.
(Sorry if there's an issue, I am a beginner.)
Fixes #4948.