Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Visual bug with hovering links and scrolling #5029

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Skinbow
Copy link

@Skinbow Skinbow commented Apr 13, 2024

Hello.

I managed to remove a visual bug with link hover underlines staying after scrolling upwards, as the link would not be refreshed when it went off-screen.
I used the assumption from the previous line (from the one where I made the change) where e.start is 0 if a scroll occurred.

I first encountered this bug on vscode.
It normally fixes microsoft/vscode#207956
I am unsure whether it fixes #4661 as I do not know how to check the change directly on vscode.

Thank you for your time and consideration.

@Skinbow
Copy link
Author

Skinbow commented Jun 26, 2024

Hello.
On my first send I seem to have encounetered a linter problem that I have since fixed.
Could you accept my pull request once more please?
Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants