Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor style on blurred terminals #603

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Conversation

parisk
Copy link
Contributor

@parisk parisk commented Mar 15, 2017

After #492 the hollow cursor style implemented in #82 broke. It displayed a filled cursor in blurred terminals, when no explicit cursor style was set (underline or bar).

This PR applies the "generic" cursor styling only when the terminal is focused.

This means that a blurred terminal will always display a hollow "block" cursor from now on.

I think that this is the best experience possible in the blurred state, since it's the same for all cursor styles and it's quite hard to think of a way to apply "blurred" state on cursor styles that are just a line (underline or bar)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.75% when pulling 9055bac on fix-blurred-terminal-cursor into eb25e88 on master.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I verified the bug/fix locally.

@parisk parisk merged commit 81419c9 into master Mar 15, 2017
@parisk parisk deleted the fix-blurred-terminal-cursor branch March 15, 2017 22:09
@Tyriar Tyriar modified the milestone: 2.5.0 Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants