Normalize line endings on paste #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tyriar This the PR I mentioned in our email exchange earlier :) |
Tyriar
reviewed
May 9, 2017
src/handlers/Clipboard.ts
Outdated
| @@ -68,6 +76,7 @@ export function pasteHandler(ev: ClipboardEvent, term: ITerminal) { | |||
| let text: string; | |||
|
|
|||
| let dispatchPaste = function(text) { | |||
| text = prepareTextForTerminal(text); | |||
There was a problem hiding this comment.
I think we should probably apply this only on Windows:
import { isMSWindows } from './Browser';
...
if (isMSWindows) {
...
}Thoughts @jdanyow?
|
I created an issue for tracking and amended the top comment so it will close off automatically 😃 |
jdanyow
commented
May 9, 2017
| * Prepares text to be pasted into the terminal by normalizing the line endings | ||
| * @param text The pasted text that needs processing before inserting into the terminal | ||
| */ | ||
| export function prepareTextForTerminal(text: string, isMSWindows: boolean): string { |
There was a problem hiding this comment.
this signature made the tests easy to implement- let me know if you'd rather see this rolled into dispatchPaste or some other form
Tyriar
approved these changes
May 9, 2017
|
@parisk coveralls doesn't seem to be completing, the build seems to have completed successfully though https://travis-ci.org/sourcelair/xterm.js/jobs/230548323 |
|
Seems to be OK now 😄 . |
|
I'm seeing some weird behavior after this. See #683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables pasting multi-line text into the terminal.
cc @EisenbergEffect, @yangl900, @DuncanmaMSFT
Fixes #660