Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull get coords into module #669

Merged
merged 4 commits into from
May 22, 2017
Merged

Pull get coords into module #669

merged 4 commits into from
May 22, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 21, 2017 •
edited
Loading

Preparation for #207

Tested by ensuring splits working in tmux with mouse mode on.

@Tyriar
Pull getCoords into a Mouse util module
4d32826 
This is part of the work to prepare for the upcoing selection changes

Related xtermjs#207
@Tyriar
jsdoc
c323e0a
@Tyriar
Polish comments and cap code
70e35de
@Tyriar Tyriar added this to the 2.7.0 milestone May 21, 2017
@Tyriar Tyriar self-assigned this May 21, 2017
@Tyriar Tyriar requested a review from parisk May 21, 2017 19:06
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 69.038% when pulling 70e35de on Tyriar:pull_getCoords_into_module into a95ac99 on sourcelair:master.

@Tyriar Tyriar mentioned this pull request May 21, 2017
Merged
64 tasks
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 69.053% when pulling 06742eb on Tyriar:pull_getCoords_into_module into 0fab4ff on sourcelair:master.

@Tyriar Tyriar merged commit db0338c into xtermjs:master May 22, 2017
@Tyriar Tyriar deleted the pull_getCoords_into_module branch May 22, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk