Restore the "paste" terminal event #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
May 27, 2017
| @@ -82,6 +82,8 @@ export function pasteHandler(ev: ClipboardEvent, term: ITerminal) { | |||
| text = prepareTextForTerminal(text, term.browser.isMSWindows); | |||
| term.handler(text); | |||
| term.textarea.value = ''; | |||
| term.emit('paste', text); | |||
There was a problem hiding this comment.
What's listening for this event exactly?
There was a problem hiding this comment.
The demo and any app that wants to consume the paste event in a single place, as it can occur both in the hidden textarea and the terminal element, depending on the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the
pasteterminal event (which is also used in the demo).Fixes #671.