Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve selection cell selection #715

Merged
merged 3 commits into from
Jun 19, 2017
Merged

Improve selection cell selection #715

merged 3 commits into from
Jun 19, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 18, 2017 •
edited
Loading

Selection starts on left of char when mouse is on left half of cell, and starts on right when mouse is on right half of cell.

Fixes #709

@Tyriar Tyriar added this to the 2.8.0 milestone Jun 18, 2017
@Tyriar Tyriar self-assigned this Jun 18, 2017
@Tyriar Tyriar requested a review from parisk June 18, 2017 19:03
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.416% when pulling c6e7fb7 on Tyriar:709_improve_selection into 663d3b2 on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.416% when pulling c6e7fb7 on Tyriar:709_improve_selection into 663d3b2 on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.698% when pulling f11362a on Tyriar:709_improve_selection into a01fbb6 on sourcelair:master.

@Tyriar Tyriar merged commit 9573357 into xtermjs:master Jun 19, 2017
@Tyriar Tyriar deleted the 709_improve_selection branch June 19, 2017 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk