Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove colon from the selection word separators #746

Merged
merged 3 commits into from
Jul 2, 2017
Merged

Remove colon from the selection word separators #746

merged 3 commits into from
Jul 2, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 1, 2017

Fixes #745

@Tyriar Tyriar added this to the 2.8.0 milestone Jul 1, 2017
@Tyriar Tyriar self-assigned this Jul 1, 2017
@Tyriar Tyriar requested a review from parisk July 1, 2017 00:08
@Tyriar Tyriar mentioned this pull request Jul 1, 2017
Closed
@Tyriar Tyriar added the work-in-progress Do not merge label Jul 1, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Jul 1, 2017

Need to fix the tests

parisk
parisk approved these changes Jul 1, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests and 🚀 .

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 69.679% when pulling 857d9bc on Tyriar:745_colon_word_sep into f80159f on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 69.679% when pulling 857d9bc on Tyriar:745_colon_word_sep into f80159f on sourcelair:master.

@Tyriar Tyriar merged commit 31aab8e into xtermjs:master Jul 2, 2017
@Tyriar Tyriar deleted the 745_colon_word_sep branch July 2, 2017 19:36
@Tyriar Tyriar removed the work-in-progress Do not merge label Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk