Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bad getOption param #793

Merged
merged 2 commits into from
Jul 13, 2017
Merged

Remove bad getOption param #793

merged 2 commits into from
Jul 13, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 13, 2017

No description provided.

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Jul 13, 2017
@Tyriar Tyriar added this to the 2.9.0 milestone Jul 13, 2017
@Tyriar Tyriar self-assigned this Jul 13, 2017
@Tyriar Tyriar requested a review from parisk July 13, 2017 16:24
@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 69.745% when pulling adc6578 on Tyriar:bad_getOption_param into 2ebc926 on sourcelair:master.

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.493% when pulling 9e95024 on Tyriar:bad_getOption_param into 87b76aa on sourcelair:master.

@Tyriar Tyriar merged commit 7cfc2ff into xtermjs:master Jul 13, 2017
@Tyriar Tyriar deleted the bad_getOption_param branch July 13, 2017 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk