Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browserify build and search addon #804

Merged
merged 10 commits into from
Jul 19, 2017
Merged

Fix browserify build and search addon #804

merged 10 commits into from
Jul 19, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 18, 2017

Fixes #803

@Tyriar Tyriar added this to the 2.9.0 milestone Jul 18, 2017
@Tyriar Tyriar self-assigned this Jul 18, 2017
@Tyriar Tyriar requested a review from parisk July 18, 2017 17:30
@Tyriar Tyriar changed the title Fix browserify build Fix browserify build and search addon Jul 18, 2017
parisk
parisk approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Tyriar
Copy link
Member Author

Tyriar commented Jul 18, 2017

Not sure why it's failing, seems to only fail on CI for me.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 70.027% when pulling 9e5b8f2 on Tyriar:803_fix_browserify into 05d308a on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 70.027% when pulling 9e5b8f2 on Tyriar:803_fix_browserify into 05d308a on sourcelair:master.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 18, 2017

The issue is happening because outDir is lib locally, but on Travis it's /home/travis/build/sourcelair/xterm.js/lib

@coveralls
Copy link

coveralls commented Jul 18, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.589% when pulling 9e5b8f2 on Tyriar:803_fix_browserify into 05d308a on sourcelair:master.

@coveralls
Copy link

coveralls commented Jul 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.589% when pulling b0c2c42 on Tyriar:803_fix_browserify into 05d308a on sourcelair:master.

@coveralls
Copy link

coveralls commented Jul 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.589% when pulling 34acdeb on Tyriar:803_fix_browserify into 05d308a on sourcelair:master.

@coveralls
Copy link

coveralls commented Jul 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.589% when pulling 3a3a4ae on Tyriar:803_fix_browserify into 05d308a on sourcelair:master.

@coveralls
Copy link

coveralls commented Jul 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.589% when pulling d531972 on Tyriar:803_fix_browserify into 05d308a on sourcelair:master.

@Tyriar Tyriar merged commit f8e3fa5 into xtermjs:master Jul 19, 2017
@Tyriar Tyriar deleted the 803_fix_browserify branch July 19, 2017 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk