Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor buffer in preparation for true color and buffer performance improvements #861

Merged
merged 2 commits into from
Aug 7, 2017
Merged

Refactor buffer in preparation for true color and buffer performance improvements #861

merged 2 commits into from
Aug 7, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 7, 2017

A refactor to prepare for buffer performance changes #791 and true color #484. These changes were previously in #756.

@Tyriar Tyriar added this to the 3.0.0 milestone Aug 7, 2017
@Tyriar Tyriar self-assigned this Aug 7, 2017
@Tyriar Tyriar requested a review from parisk August 7, 2017 22:42
@coveralls
Copy link

coveralls commented Aug 7, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 71.221% when pulling fd61c8e on Tyriar:791_buffer_refactor into 091854d on sourcelair:v3.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 7, 2017

FYI @parisk, I'm merging this as CI passed, it's low risk and was already signed off in #756

@Tyriar Tyriar merged commit f52b43b into xtermjs:v3 Aug 7, 2017
@Tyriar Tyriar deleted the 791_buffer_refactor branch August 7, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk Awaiting requested review from parisk

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @coveralls